Remove scala.internal.quoted.LiftedExpr #6793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
remove-LiftedExpr
branch
3 times, most recently
from
8925d6f to
0609c54
Compare
nicolasstucki
force-pushed
the
remove-LiftedExpr
branch
2 times, most recently
from
4b86e2c to
17675b7
Compare
Use reflection to implement `Liftable` for primitive types.
nicolasstucki
force-pushed
the
remove-LiftedExpr
branch
from
17675b7 to
65901c5
Compare
liufengyun
approved these changes
Jul 4, 2019
| @@ -1454,6 +1480,9 @@ class KernelImpl(val rootContext: core.Contexts.Context, val rootPosition: util. | |||
| def matchConstant_ClassTag(x: Constant): Option[Type] = | |||
| if (x.tag == Constants.ClazzTag) Some(x.typeValue) else None | |||
|
|
|||
| def Constant_apply(x: Unit | Null | Int | Boolean | Byte | Short | Int | Long | Float | Double | Char | String | Type): Constant = | |||
| Constants.Constant(x) | |||
There was a problem hiding this comment.
That is the encoding for a classOf[T]
| case _: String => liftedValue(value, "Liftable_String_delegate".toTermName, qctx) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
We still need special compiler support for lifting primitives? Or it's for backward-compatibility.
There was a problem hiding this comment.
We do not need it anymore.
| @@ -64,6 +64,8 @@ trait TypeOrBoundsOps extends Core { | |||
|
|
|||
| object Type { | |||
|
|
|||
| def apply(clazz: Class[_])(implicit ctx: Context): Type = kernel.Type_apply(clazz) | |||
|
|
|||
| object IsConstantType { | |||
There was a problem hiding this comment.
Why the two neg-with-compiler tests are disabled?
There was a problem hiding this comment.
Those tests where testing scope extrusion detection through an euristic which happens to no work anymore. I will work on more reliable mechanism for scope extrusion detection later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Liftablefor primitive typesLiftable[Byte]Expr.nullExprandExpr.unitExprto lift those values without pickling